Commit b93e775b authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Jim Harris
Browse files

nvmf: deprecate [listen_]address.transport 



Change-Id: Icb805a2b0514695fe3e198c4e92935e90e91d0ec
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22914


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
parent 956cffa0

lib/nvmf/nvmf_rpc.c

+13 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
#include "nvmf_internal.h"



static bool g_logged_deprecated_nvmf_get_subsystems = false;

static bool g_logged_deprecated_decode_rpc_listen_address = false;



static int rpc_ana_state_parse(const char *str, enum spdk_nvme_ana_state *ana_state);
@@ -599,16 +600,28 @@ static const struct spdk_json_object_decoder rpc_listen_address_decoders[] = { 
	{"trsvcid", offsetof(struct rpc_listen_address, trsvcid), spdk_json_decode_string, true},

};



SPDK_LOG_DEPRECATION_REGISTER(decode_rpc_listen_address,

			      "[listen_]address.transport is deprecated in favor of trtype",

			      "v24.09", 0);



static int

decode_rpc_listen_address(const struct spdk_json_val *val, void *out)

{

	struct rpc_listen_address *req = (struct rpc_listen_address *)out;



	if (spdk_json_decode_object(val, rpc_listen_address_decoders,

				    SPDK_COUNTOF(rpc_listen_address_decoders),

				    req)) {

		SPDK_ERRLOG("spdk_json_decode_object failed\n");

		return -1;

	}



	/* Log only once */

	if (req->transport && !g_logged_deprecated_decode_rpc_listen_address) {

		SPDK_LOG_DEPRECATED(decode_rpc_listen_address);

		g_logged_deprecated_decode_rpc_listen_address = true;

	}



	return 0;

}