Commit b872e29f authored by Kozlowski Mateusz's avatar Kozlowski Mateusz Committed by Konrad Sztyber
Browse files

FTL: Add config checks during startup flow 



Signed-off-by: default avatarKozlowski Mateusz <mateusz.kozlowski@intel.com>
Signed-off-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I336880ee263dbb23b613bd933c776f0b922412cc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13294


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 7a7ac2af

lib/ftl/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ FTL_SUBDIRS := mngt utils 


C_SRCS = ftl_core.c ftl_init.c ftl_layout.c

C_SRCS += mngt/ftl_mngt.c mngt/ftl_mngt_bdev.c mngt/ftl_mngt_shutdown.c mngt/ftl_mngt_startup.c

C_SRCS += mngt/ftl_mngt_md.c

C_SRCS += mngt/ftl_mngt_md.c mngt/ftl_mngt_misc.c

C_SRCS += utils/ftl_conf.c utils/ftl_md.c



SPDK_MAP_FILE = $(abspath $(CURDIR)/spdk_ftl.map)

lib/ftl/mngt/ftl_mngt_misc.c

0 → 100644
+20 −0
Original line number Diff line number Diff line 
/*   SPDX-License-Identifier: BSD-3-Clause

 *   Copyright (c) Intel Corporation.

 *   All rights reserved.

 */



#include "ftl_core.h"

#include "ftl_utils.h"

#include "ftl_mngt.h"

#include "ftl_mngt_steps.h"

#include "ftl_internal.h"



void

ftl_mngt_check_conf(struct spdk_ftl_dev *dev, struct ftl_mngt_process *mngt)

{

	if (ftl_conf_is_valid(&dev->conf)) {

		ftl_mngt_next_step(mngt);

	} else {

		ftl_mngt_fail_step(mngt);

	}

}

lib/ftl/mngt/ftl_mngt_startup.c

+4 −0
Original line number Diff line number Diff line
@@ -12,6 +12,10 @@ static const struct ftl_mngt_process_desc desc_startup; 
static const struct ftl_mngt_process_desc desc_startup = {

	.name = "FTL startup",

	.steps = {

		{

			.name = "Check configuration",

			.action = ftl_mngt_check_conf,

		},

		{

			.name = "Open base bdev",

			.action = ftl_mngt_open_base_bdev,

lib/ftl/mngt/ftl_mngt_steps.h

+2 −0
Original line number Diff line number Diff line
@@ -8,6 +8,8 @@ 


#include "ftl_mngt.h"



void ftl_mngt_check_conf(struct spdk_ftl_dev *dev, struct ftl_mngt_process *mngt);



void ftl_mngt_open_base_bdev(struct spdk_ftl_dev *dev, struct ftl_mngt_process *mngt);



void ftl_mngt_close_base_bdev(struct spdk_ftl_dev *dev, struct ftl_mngt_process *mngt);

lib/ftl/utils/ftl_conf.c

+13 −0
Original line number Diff line number Diff line
@@ -101,3 +101,16 @@ ftl_conf_init_dev(struct spdk_ftl_dev *dev, const struct spdk_ftl_conf *conf) 


	return 0;

}



bool

ftl_conf_is_valid(const struct spdk_ftl_conf *conf)

{

	if (conf->overprovisioning >= 100) {

		return false;

	}

	if (conf->overprovisioning == 0) {

		return false;

	}



	return true;

}