Commit b813f998 authored by yidong0635's avatar yidong0635 Committed by Tomasz Zawadzki
Browse files

nvme_pcie_common: Move group right before using. 



Better not to cache a value especially for there's an error return.

Signed-off-by: default avataryidong0635 <dongx.yi@intel.com>
Change-Id: I3b243a66f4db9af34bc2ea01bafdac33004be128
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13650


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 510f4c13

lib/nvme/nvme_pcie_common.c

+1 −1
Original line number Diff line number Diff line
@@ -1791,13 +1791,13 @@ nvme_pcie_poll_group_get_stats(struct spdk_nvme_transport_poll_group *tgroup, 
		return -EINVAL;

	}



	group = SPDK_CONTAINEROF(tgroup, struct nvme_pcie_poll_group, group);

	stats = calloc(1, sizeof(*stats));

	if (!stats) {

		SPDK_ERRLOG("Can't allocate memory for RDMA stats\n");

		return -ENOMEM;

	}

	stats->trtype = SPDK_NVME_TRANSPORT_PCIE;

	group = SPDK_CONTAINEROF(tgroup, struct nvme_pcie_poll_group, group);

	memcpy(&stats->pcie, &group->stats, sizeof(group->stats));



	*_stats = stats;