Commit b7964a3c authored Nov 28, 2022 by Konrad Sztyber Committed by Tomasz Zawadzki Dec 16, 2022

sma: forbid deleting devices with attached volumes



It makes it possible for stateless clients to send CreateDevice /
DeleteDevice each time a volume is attached / detached.  Deleting a
device with attached volumes results in FAILED_PRECONDITION error, which
a client can simply ignore.  The device will be deleted during the final
DeleteDevice call, once all volumes are detached.

We limit this behavior to device types that support AttachVolume /
DetachVolume methods, otherwise it would be impossible to delete such
devices.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I244b2b09455ec1430970c70f3fbb739cc9069754
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15670


Reviewed-by: Jing Yan <jing1.yan@intel.com>
Reviewed-by: Filip Szufnarowski <filip.szufnarowski@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent 5a3e64ef

proto/sma.proto

+4 −1

Original line number	Diff line number	Diff line
		@@ -172,7 +172,10 @@ service StorageManagementAgent {
		// volumes (e.g. an NVMeoF subsystem).
		rpc CreateDevice (CreateDeviceRequest)
		returns (CreateDeviceResponse) {}
		// Deletes a device
		// Deletes a device. It is only allowed to delete a device with volumes still
		// attached if that device doesn't support attaching volumes through
		// AttachVolume (e.g. virtio-blk). In other cases, it is forbidden and
		// FAILED_PRECONDITION status will be returned.
		rpc DeleteDevice (DeleteDeviceRequest)
		returns (DeleteDeviceResponse) {}
		// Attaches a volume to a specified device making it available through that

python/spdk/sma/device/device.py

+3 −1

Original line number	Diff line number	Diff line
		@@ -12,10 +12,12 @@ class DeviceException(Exception):


		class DeviceManager:
		def __init__(self, name, protocol, client):
		def __init__(self, name, protocol, client, allow_delete_volumes=False):
		self._client = client
		self.protocol = protocol
		self.name = name
		# Configures whether the device allows deleting a device with attached volumes
		self.allow_delete_volumes = allow_delete_volumes

		def init(self, config):
		pass

python/spdk/sma/device/vhost_blk.py

+1 −1

Original line number	Diff line number	Diff line
		@@ -20,7 +20,7 @@ from .device import DeviceException, DeviceManager

		class VhostBlkDeviceManager(DeviceManager):
		def __init__(self, client):
		super().__init__('vhost_blk', 'virtio_blk', client)
		super().__init__('vhost_blk', 'virtio_blk', client, allow_delete_volumes=True)

		def init(self, config):
		self._buses = config.get('buses', [])

python/spdk/sma/sma.py

+5 −1

Original line number	Diff line number	Diff line
		@@ -97,8 +97,12 @@ class StorageManagementAgent(pb2_grpc.StorageManagementAgentServicer):
		if device is None:
		raise DeviceException(grpc.StatusCode.NOT_FOUND,
		'Invalid device handle')
		if not device.allow_delete_volumes and self._volume_mgr.has_volumes(request.handle):
		raise DeviceException(grpc.StatusCode.FAILED_PRECONDITION,
		'Device has attached volumes')
		device.delete_device(request)
		# Remove all volumes attached to that device
		# Either there are no volumes attached to this device or we're allowed to delete it
		# with volumes still attached
		self._volume_mgr.disconnect_device_volumes(request.handle)
		except DeviceException as ex:
		context.set_details(ex.message)

python/spdk/sma/volume/volume.py

+6 −0

Original line number	Diff line number	Diff line
		@@ -320,3 +320,9 @@ class VolumeManager:
		volumes = [i for i, v in self._volumes.items() if v.device_handle == device_handle]
		for volume_id in volumes:
		self._disconnect_volume(volume_id)

		@_locked
		def has_volumes(self, device_handle):
		"""Checks whether a given device has volumes attached to it"""
		return next(filter(lambda v: v.device_handle == device_handle,
		self._volumes.values()), None) is not None