Commit b7775dae authored by Changpeng Liu's avatar Changpeng Liu Committed by Jim Harris
Browse files

nvmf/vfio-user: add memory barrier after posting a completion 



We met an issue that client got a NVMe completion with old SC
bit, so we add a memory barrier here to ensure the NVMe completion
is fully populated.

Fix issue #2323.

Change-Id: I7887d789a0acd3634a10aa7dc8de81a153137ae7
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11076


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJohn Levon <levon@movementarian.org>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent d87afb4c

lib/nvmf/vfio_user.c

+3 −1
Original line number Diff line number Diff line
@@ -939,9 +939,11 @@ post_completion(struct nvmf_vfio_user_ctrlr *ctrlr, struct nvme_q *cq, 
	cpl->status.dnr = 0x0;

	cpl->status.m = 0x0;

	cpl->status.sct = sct;

	cpl->status.p = cq->phase;

	cpl->status.sc = sc;

	cpl->status.p = cq->phase;



	/* Ensure the Completion Queue Entry is visible. */

	spdk_wmb();

	cq_tail_advance(cq);



	/*