Commit b7651b68 authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

NVMe-oF: add asserts for SGE counts 



We should never be going over these limits in the respective transports,
but add asserts to check this during testing.

Change-Id: Ifcaa82ccf58546a38020b31df54ee5d1d9822b8b
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/442777


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent f4d6841b

lib/nvmf/rdma.c

+2 −0
Original line number Diff line number Diff line
@@ -1278,6 +1278,8 @@ spdk_nvmf_rdma_request_fill_iovs(struct spdk_nvmf_rdma_transport *rtransport, 
		i++;

	}



	assert(rdma_req->req.iovcnt <= rqpair->max_send_sge);



	rdma_req->data_from_pool = true;



	return rc;

lib/nvmf/tcp.c

+1 −0
Original line number Diff line number Diff line
@@ -2116,6 +2116,7 @@ spdk_nvmf_tcp_req_fill_iovs(struct spdk_nvmf_tcp_transport *ttransport, 
		i++;

	}



	assert(tcp_req->req.iovcnt < SPDK_NVMF_MAX_SGL_ENTRIES);

	tcp_req->data_from_pool = true;

	return 0;

test/unit/lib/nvmf/rdma.c/rdma_ut.c

+1 −0
Original line number Diff line number Diff line
@@ -128,6 +128,7 @@ test_spdk_nvmf_rdma_request_parse_sgl(void) 
	group.group.buf_cache_count = 0;

	poller.group = &group;

	rqpair.poller = &poller;

	rqpair.max_send_sge = SPDK_NVMF_MAX_SGL_ENTRIES;



	sgl = &cmd.nvme_cmd.dptr.sgl1;

	rdma_req.recv = &recv;