Commit b6db1af7 authored Feb 19, 2025 by Maciej Szulik Committed by Jim Harris Apr 17, 2025

sock: rely on defined uint wrap behavior in check_zcopy



Wrapping for unsigned integers is a defined behavior, there is no need
for if/else here.

Signed-off-by: Maciej Szulik <maciej.szulik@intel.com>
Suggested-by: Jacek Kalwas <jacek.kalwas@intel.com>
Change-Id: Ibb99dc6dad753e9539205749f5418c66fa61e8c8
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25657


Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: GangCao <gang.cao@intel.com>

parent 71828666

module/sock/posix/posix.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -1330,13 +1330,9 @@ _sock_check_zcopy(struct spdk_sock *sock)
		break;
		}

		if (idx == UINT32_MAX) {
		idx = 0;
		} else {
		idx++;
		}
		}
		}

		return 0;
		}

module/sock/uring/uring.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -1199,12 +1199,8 @@ _sock_check_zcopy(struct spdk_sock *_sock, int status)
		break;
		}

		if (idx == UINT32_MAX) {
		idx = 0;
		} else {
		idx++;
		}
		}

		return 0;
		}