Commit b56f1ef5 authored by Matthew King's avatar Matthew King Committed by Tomasz Zawadzki
Browse files

Cleanup: Fix boolean arg in fio plugin. 



In fio, bools are represented as ints.  They have to be read into int entries
in the options struct, or memory corruption may occur.
Also provided a default to bring it more in line with existing fio code.

Signed-off-by: default avatarMatthew King <matthew.king@xilinx.com>
Change-Id: Ib718653d6597a287bf8ff96d2fb864e46295751d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6147


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatar <dongx.yi@intel.com>
parent ed1dcc1c

examples/bdev/fio_plugin/fio_plugin.c

+2 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ struct spdk_fio_options { 
	char *conf;

	char *json_conf;

	unsigned mem_mb;

	bool mem_single_seg;

	int mem_single_seg;

};



struct spdk_fio_request {
@@ -789,6 +789,7 @@ static struct fio_option options[] = { 
		.type		= FIO_OPT_BOOL,

		.off1		= offsetof(struct spdk_fio_options, mem_single_seg),

		.help		= "If set to 1, SPDK will use just a single hugetlbfs file",

		.def            = "0",

		.category	= FIO_OPT_C_ENGINE,

		.group		= FIO_OPT_G_INVALID,

	},