Commit b3d0c369 authored May 15, 2020 by Shuhei Matsumoto Committed by Tomasz Zawadzki Jun 24, 2020

lib/nvme: Fix wrong completion status when retrying queued abort command



next->cpl should have been set if nvme_ctrlr_submit_admin_request()
failed in spdk_nvme_ctrlr_cmd_abort_cpl().

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I4114294e398b18148d8a9ad798a656a7686c5a85
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2491


Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Michael Haeuptle <michaelhaeuptle@gmail.com>

parent 8c710c9d

lib/nvme/nvme_ctrlr_cmd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -585,7 +585,7 @@ nvme_ctrlr_cmd_abort_cpl(void ctx, const struct spdk_nvme_cpl cpl)
		next->cpl.status.sct = SPDK_NVME_SCT_GENERIC;
		next->cpl.status.sc = SPDK_NVME_SC_INTERNAL_DEVICE_ERROR;
		next->cpl.status.dnr = 1;
		nvme_complete_request(next->cb_fn, next->cb_arg, next->qpair, next, &req->cpl);
		nvme_complete_request(next->cb_fn, next->cb_arg, next->qpair, next, &next->cpl);
		nvme_free_request(next);
		} else {
		/* If the first abort succeeds, stop iterating. */

Admin message