Commit b2fb5519 authored by Changpeng Liu's avatar Changpeng Liu
Browse files

scsi: fix possible memory leak for unmap command 



Althrough it has very small chance to be executed, it's nice
to have it fixed.

Change-Id: I899681ccc13ed59c7fdd343ef7791df4e69e490f
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/433976


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 1f20593b

lib/scsi/scsi_bdev.c

+3 −3
Original line number Diff line number Diff line
@@ -1592,7 +1592,7 @@ spdk_bdev_scsi_unmap(struct spdk_bdev *bdev, struct spdk_bdev_desc *bdev_desc, 
		     struct spdk_io_channel *bdev_ch, struct spdk_scsi_task *task, struct spdk_bdev_scsi_unmap_ctx *ctx)

{

	uint8_t				*data;

	int				desc_count, i;

	int				i, desc_count = -1;

	int				data_len;

	int				rc;
@@ -1619,8 +1619,8 @@ spdk_bdev_scsi_unmap(struct spdk_bdev *bdev, struct spdk_bdev_desc *bdev_desc, 
		desc_count = __copy_desc(ctx, data, data_len);

	} else {

		data = spdk_scsi_task_gather_data(task, &data_len);

		if (data) {

			desc_count = __copy_desc(ctx, data, data_len);

		if (desc_count < 0) {

			spdk_dma_free(data);

		}

	}