Commit b2b3fa9e authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Konrad Sztyber
Browse files

scripts/rpc: Add optional print for uuid in bdev_null/malloc_create 



These are tagged as optional in the parsing of the argument, adding the
info to the help, so the user doesn't feel the need to fill this in when
creating a new instance.

Change-Id: I7bd18a58d9c38d243445dd843128026cc7f5dbd3
Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24721


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
parent e5693d68

scripts/rpc.py

+2 −2
Original line number Diff line number Diff line
@@ -418,7 +418,7 @@ if __name__ == "__main__": 
                                               dif_pi_format=args.dif_pi_format))

    p = subparsers.add_parser('bdev_malloc_create', help='Create a bdev with malloc backend')

    p.add_argument('-b', '--name', help="Name of the bdev")

    p.add_argument('-u', '--uuid', help="UUID of the bdev")

    p.add_argument('-u', '--uuid', help="UUID of the bdev (optional)")

    p.add_argument(

        'total_size', help='Size of malloc bdev in MB (float > 0)', type=float)

    p.add_argument('block_size', help='Data block size for this bdev', type=int)
@@ -465,7 +465,7 @@ if __name__ == "__main__": 


    p = subparsers.add_parser('bdev_null_create', help='Add a bdev with null backend')

    p.add_argument('name', help='Block device name')

    p.add_argument('-u', '--uuid', help='UUID of the bdev')

    p.add_argument('-u', '--uuid', help='UUID of the bdev (optional)')

    p.add_argument('total_size', help='Size of null bdev in MB (int > 0). Includes only data blocks.', type=int)

    p.add_argument('block_size', help='Data block size for this bdev.', type=int)

    p.add_argument('-p', '--physical-block-size', help='Physical block size for this bdev.', type=int)