+1
−1
Loading
When adding an additional state to enum nvme_ctrlr_state, abidiff (1.6.0) will report that almost every public interface in the nvme library has been impacted, causing test/make/check_so_deps.sh to fail. While it is possible that by adding another state, the compiler decides to use a larger data type for representing enum nvme_ctrlr_state, abidiff shouldn't complain in the first place, since spdk_nvme_ctrlr is only ever exposed as an opaque handle. It can never be accessed directly. Jim Harris suggested to workaround this abidiff bug by changing the type of spdk_nvme_ctrlr::state from enum to int. Signed-off-by:Niklas Cassel <niklas.cassel@wdc.com> Change-Id: I8b85446580043e95cf791249d643907587e2f982 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4427 Tested-by:
SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by:
Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by:
Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by:
Ben Walker <benjamin.walker@intel.com> Reviewed-by:
Jim Harris <james.r.harris@intel.com>