Commit b237c1b5 authored by Darek Stojaczyk's avatar Darek Stojaczyk Committed by Jim Harris
Browse files

bdev/virtio: deprecate remove_virtio_scsi_bdev RPC 



`remove_virtio_bdev` RPC can be used instead. It deletes
both Virtio Block and SCSI devices.

Change-Id: I3504f8d27eb13bb7522c05041c21042153a4fa18
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/429909


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
parent f3096dac

CHANGELOG.md

+5 −2
Original line number Diff line number Diff line
@@ -122,9 +122,12 @@ The following RPC commands have been deprecated: 
 - construct_virtio_pci_scsi_bdev

 - construct_virtio_user_blk_bdev

 - construct_virtio_pci_blk_bdev

 - remove_virtio_scsi_bdev



They're replaced with a single `construct_virtio_dev` command that can create

any type of Virtio bdev(s).

The `construct_virtio_*` ones were replaced with a single `construct_virtio_dev`

command that can create any type of Virtio bdev(s). `remove_virtio_scsi_bdev`

was replaced with `remove_virtio_bdev` that can delete both Virtio Block and SCSI

devices.



## v18.07:

lib/bdev/virtio/bdev_virtio_rpc.c

+3 −0
Original line number Diff line number Diff line
@@ -236,6 +236,9 @@ spdk_rpc_remove_virtio_scsi_bdev(struct spdk_jsonrpc_request *request, 
	struct rpc_remove_virtio_dev req = {NULL};

	int rc;



	SPDK_WARNLOG("remove_virtio_scsi_bdev command has been deprecated and will be removed "

		     "in the subsequent release. Please use remove_virtio_bdev instead.\n");



	if (spdk_json_decode_object(params, rpc_remove_virtio_dev,

				    SPDK_COUNTOF(rpc_remove_virtio_dev),

				    &req)) {