Commit af729655 authored by Niklas Cassel's avatar Niklas Cassel Committed by Tomasz Zawadzki
Browse files

bdev/fio_plugin: fix scan-build error 



spdk_fio_init_thread() assigns td->io_ops_data.
spdk_fio_init_thread() can return an error, but currently lacks error
handling code.

Add error handling code, and add an assertion that fio_thread
(td->io_ops_data) is assigned when spdk_fio_init_thread() didn't return
an error.

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Change-Id: I8de7d59db0373599c90aa57fffa476c6707b6104
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7732


Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 82e4bfd3

examples/bdev/fio_plugin/fio_plugin.c

+6 −1
Original line number Diff line number Diff line
@@ -539,10 +539,15 @@ static int 
spdk_fio_init(struct thread_data *td)

{

	struct spdk_fio_thread *fio_thread;

	int rc;



	spdk_fio_init_thread(td);

	rc = spdk_fio_init_thread(td);

	if (rc) {

		return rc;

	}



	fio_thread = td->io_ops_data;

	assert(fio_thread);

	fio_thread->failed = false;



	spdk_thread_send_msg(fio_thread->thread, spdk_fio_bdev_open, td);