Commit af2d56ed authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

lib/nvme: Don't re-queue I/O while disconnecting. 



This can cause infinite loops if the callback tries to
queue an additional I/O.

Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Change-Id: I4b80b97d334082465d9228b799ef901645fa968e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1854


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent b874f657

lib/nvme/nvme_qpair.c

+5 −0
Original line number Diff line number Diff line
@@ -725,6 +725,11 @@ nvme_qpair_submit_request(struct spdk_nvme_qpair *qpair, struct nvme_request *re 
{

	int rc;



	/* This prevents us from entering an infinite loop when freeing queued I/O in disconnect. */

	if (spdk_unlikely(nvme_qpair_get_state(qpair) == NVME_QPAIR_DISCONNECTING)) {

		return -ENXIO;

	}



	if (spdk_unlikely(!STAILQ_EMPTY(&qpair->queued_req) && req->num_children == 0)) {

		/*

		 * requests that have no children should be sent to the transport after all