Commit ae74e70e authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

lib/event: remove _spdk_scheduler_disable() 



Remove _spdk_scheduler_disable() to avoid confusion as there is
no spdk_scheduler_enable function. Since spdk_scheduler_disable
sets scheduler period to 0, use spdk_scheduler_period_set(0) instead.

Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I4f1390a635f80e8b92775aa4be2e37f5b95467f8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7448


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
parent fba4a97d

include/spdk_internal/event.h

+0 −5
Original line number Diff line number Diff line
@@ -342,11 +342,6 @@ struct spdk_scheduler *_spdk_scheduler_get(void); 
 */

void _spdk_scheduler_period_set(uint64_t period);



/**

 * Disable the scheduler.

 */

void _spdk_scheduler_disable(void);



/**

 * Get period of currently set scheduler.

 */

lib/event/app.c

+1 −1
Original line number Diff line number Diff line
@@ -617,7 +617,7 @@ app_stop(void *arg1) 


	spdk_rpc_finish();

	g_spdk_app.stopped = true;

	_spdk_scheduler_disable();

	_spdk_scheduler_period_set(0);

	_start_subsystem_fini(NULL);

}

lib/event/reactor.c

+0 −6
Original line number Diff line number Diff line
@@ -154,12 +154,6 @@ _spdk_scheduler_period_set(uint64_t period) 
	g_scheduler_period = period * spdk_get_ticks_hz() / SPDK_SEC_TO_USEC;

}



void

_spdk_scheduler_disable(void)

{

	g_scheduler_period = 0;

}



void

_spdk_scheduler_list_add(struct spdk_scheduler *scheduler)

{

test/unit/lib/event/app.c/app_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ DEFINE_STUB_V(spdk_reactors_start, (void)); 
DEFINE_STUB_V(spdk_reactors_stop, (void *arg1));

DEFINE_STUB(spdk_reactors_init, int, (void), 0);

DEFINE_STUB_V(spdk_reactors_fini, (void));

DEFINE_STUB_V(_spdk_scheduler_disable, (void));

DEFINE_STUB_V(_spdk_scheduler_period_set, (uint64_t period));

bool g_scheduling_in_progress;



static void