Commit ae693db9 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

iscsi: fix memleak when iscsi_read_config_file_params() fails 



All error paths must free opts->nodebase and opts->authfile.

Change-Id: I655f112dd36bbd0dca6050bc5cc3ade1a5b05b7d
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451770


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 598795ba

lib/iscsi/iscsi_subsystem.c

+2 −0
Original line number Diff line number Diff line
@@ -599,6 +599,8 @@ iscsi_read_config_file_params(struct spdk_conf_section *sp, 
			}

		}

		if (opts->mutual_chap && !opts->require_chap) {

			free(opts->authfile);

			free(opts->nodebase);

			SPDK_ERRLOG("CHAP must set to be required when using mutual CHAP.\n");

			return -EINVAL;

		}