Commit ae207216 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvmf: remove request exec backdoor 



It was introduced for the purpose of executing fabric cmds when
subsystem and qpairs are not active. It was rather workaround than
solution for transport type like vfio-user. spdk_nvmf_request_exec
is a preferred way of passing request obj into nvmf layer.

Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I4f989de27bfd494c744017599909c2e200f0f233
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4180


Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent ce7eee98

include/spdk/nvmf_transport.h

+0 −1
Original line number Diff line number Diff line
@@ -410,7 +410,6 @@ int spdk_nvmf_request_get_buffers_multi(struct spdk_nvmf_request *req, 
bool spdk_nvmf_request_get_dif_ctx(struct spdk_nvmf_request *req, struct spdk_dif_ctx *dif_ctx);



void spdk_nvmf_request_exec(struct spdk_nvmf_request *req);

void spdk_nvmf_request_exec_fabrics(struct spdk_nvmf_request *req);

int spdk_nvmf_request_free(struct spdk_nvmf_request *req);

int spdk_nvmf_request_complete(struct spdk_nvmf_request *req);

lib/nvmf/ctrlr.c

+0 −18
Original line number Diff line number Diff line
@@ -3335,24 +3335,6 @@ _nvmf_request_exec(struct spdk_nvmf_request *req, 
	}

}



void

spdk_nvmf_request_exec_fabrics(struct spdk_nvmf_request *req)

{

	struct spdk_nvmf_qpair *qpair = req->qpair;

	struct spdk_nvmf_subsystem_poll_group *sgroup = NULL;



	assert(req->cmd->nvmf_cmd.opcode == SPDK_NVME_OPC_FABRIC);



	if (qpair->ctrlr) {

		sgroup = &qpair->group->sgroups[qpair->ctrlr->subsys->id];

		assert(sgroup != NULL);

	} else {

		sgroup = nvmf_subsystem_pg_from_connect_cmd(req);

	}



	_nvmf_request_exec(req, sgroup);

}



void

spdk_nvmf_request_exec(struct spdk_nvmf_request *req)

{

lib/nvmf/spdk_nvmf.map

+0 −1
Original line number Diff line number Diff line
@@ -107,7 +107,6 @@ 
	spdk_nvmf_request_get_buffers_multi;

	spdk_nvmf_request_get_dif_ctx;

	spdk_nvmf_request_exec;

	spdk_nvmf_request_exec_fabrics;

	spdk_nvmf_request_free;

	spdk_nvmf_request_complete;

	spdk_nvmf_ctrlr_get_subsystem;