Commit ae19968f authored by Boris Glimcher's avatar Boris Glimcher Committed by Jim Harris
Browse files

nvmf/rdma: fixing clang error: applying zero offset to null pointer 



Fixes: #3722

Change-Id: I8c634182fdc62238768a3b2a89eb8b78d59bf54b
Signed-off-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26590


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
parent 38a4ea77

lib/nvmf/rdma.c

+3 −0
Original line number Diff line number Diff line
@@ -1887,6 +1887,9 @@ nvmf_rdma_request_parse_icd(struct spdk_nvmf_rdma_transport *rtransport, 
	req->data_from_pool = false;

	req->length = sgl->unkeyed.length;



	assert(rdma_req->recv != NULL);

	assert(rdma_req->recv->buf != NULL);



	req->iov[0].iov_base = rdma_req->recv->buf + offset;

	req->iov[0].iov_len = req->length;

	req->iovcnt = 1;

test/unit/lib/nvmf/rdma.c/rdma_ut.c

+2 −0
Original line number Diff line number Diff line
@@ -435,6 +435,7 @@ create_recv(struct spdk_nvmf_rdma_qpair *rqpair, enum spdk_nvme_nvm_opcode opc) 


	rdma_recv = calloc(1, sizeof(*rdma_recv));

	rdma_recv->qpair = rqpair;

	rdma_recv->buf = (void *)0xDDDD;

	cmd = calloc(1, sizeof(*cmd));

	rdma_recv->sgl[0].addr = (uintptr_t)cmd;

	cmd->nvme_cmd.opc = opc;
@@ -464,6 +465,7 @@ create_req(struct spdk_nvmf_rdma_qpair *rqpair, 


	rdma_req = calloc(1, sizeof(*rdma_req));

	rdma_req->recv = rdma_recv;

	rdma_req->recv->buf = (void *)0xDDDD;

	rdma_req->req.qpair = &rqpair->qpair;

	rdma_req->state = RDMA_REQUEST_STATE_NEW;

	rdma_req->data.wr.wr_id = (uintptr_t)&rdma_req->data_wr;