Commit acca0749 authored by Niklas Cassel's avatar Niklas Cassel Committed by Tomasz Zawadzki
Browse files

nvme/fio_plugin: change zone append print to SPDK_DEBUGLOG 



Change zone append print to SPDK_DEBUGLOG() instead of an unconditional
print. Since we already print a warning when zone append isn't supported,
there is no need to unconditionally print something for the success case.
This also matches the behavior of the SPDK fio bdev plugin.

Also improve the zone append help text to match the SPDK fio bdev plugin.

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Change-Id: Ic7604ea4bdf17e0cddfe2638f3db7944ee652474
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7804


Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 367784a6

examples/nvme/fio_plugin/fio_plugin.c

+6 −4
Original line number Diff line number Diff line
@@ -426,12 +426,12 @@ attach_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid, 


	if (fio_options->zone_append && spdk_nvme_ns_get_csi(ns) == SPDK_NVME_CSI_ZNS) {

		if (spdk_nvme_ctrlr_get_flags(ctrlr) & SPDK_NVME_CTRLR_ZONE_APPEND_SUPPORTED) {

			fprintf(stdout, "Using zone appends instead of writes on: '%s'\n",

				fio_qpair->f->file_name);

			SPDK_DEBUGLOG(fio_nvme, "Using zone appends instead of writes on: '%s'\n",

				      f->file_name);

			fio_qpair->zone_append_enabled = true;

		} else {

			SPDK_WARNLOG("Falling back to writes on: '%s' - ns lacks zone append cmd\n",

				     fio_qpair->f->file_name);

				     f->file_name);

		}

	}
@@ -1634,7 +1634,7 @@ static struct fio_option options[] = { 
		.type		= FIO_OPT_INT,

		.off1		= offsetof(struct spdk_fio_options, zone_append),

		.def		= "0",

		.help		= "Use zone append instead of write (zone_append=1 or zone_append=0)",

		.help		= "Use zone append instead of write (1=zone append, 0=write)",

		.category	= FIO_OPT_C_ENGINE,

		.group		= FIO_OPT_G_INVALID,

	},
@@ -1688,3 +1688,5 @@ static void fio_exit fio_spdk_unregister(void) 
{

	unregister_ioengine(&ioengine);

}



SPDK_LOG_REGISTER_COMPONENT(fio_nvme)