Commit abeae984 authored by Yan Wang's avatar Yan Wang Committed by Tomasz Zawadzki
Browse files

lib/blob: check return value after malloc() and strdup() 



Signed-off-by: default avatarYan Wang <wangyan122@huawei.com>
Change-Id: Ieaaecfd12ddf7826c2e4ce6dc5f47411e7e077da
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2907


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
parent 1befc43b

lib/blob/blobstore.c

+18 −1
Original line number Diff line number Diff line
@@ -7111,6 +7111,7 @@ blob_set_xattr(struct spdk_blob *blob, const char *name, const void *value, 
	struct spdk_xattr_tailq *xattrs;

	struct spdk_xattr	*xattr;

	size_t			desc_size;

	void			*tmp;



	blob_verify_md_op(blob);
@@ -7134,9 +7135,14 @@ blob_set_xattr(struct spdk_blob *blob, const char *name, const void *value, 


	TAILQ_FOREACH(xattr, xattrs, link) {

		if (!strcmp(name, xattr->name)) {

			tmp = malloc(value_len);

			if (!tmp) {

				return -ENOMEM;

			}



			free(xattr->value);

			xattr->value_len = value_len;

			xattr->value = malloc(value_len);

			xattr->value = tmp;

			memcpy(xattr->value, value, value_len);



			blob->state = SPDK_BLOB_STATE_DIRTY;
@@ -7149,9 +7155,20 @@ blob_set_xattr(struct spdk_blob *blob, const char *name, const void *value, 
	if (!xattr) {

		return -ENOMEM;

	}



	xattr->name = strdup(name);

	if (!xattr->name) {

		free(xattr);

		return -ENOMEM;

	}



	xattr->value_len = value_len;

	xattr->value = malloc(value_len);

	if (!xattr->value) {

		free(xattr->name);

		free(xattr);

		return -ENOMEM;

	}

	memcpy(xattr->value, value, value_len);

	TAILQ_INSERT_TAIL(xattrs, xattr, link);