Commit ab3ff5a1 authored by Jaroslaw Chachulski's avatar Jaroslaw Chachulski Committed by Tomasz Zawadzki
Browse files

scripts/nvmf: Enhance Pause Frames Configuration 



Description:
- Modified the pause frames configuration method to handle
  three scenarios explicitly:
   - Retaining NIC's default pause frames settings when no
     specific configuration is present.
   - Disabling pause frames based on explicit configuration.
   - Enabling pause frames based on explicit configuration.

Signed-off-by: default avatarJaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: Ia4d0f6275292ff0a9b750bf0d9e617e2c1714065
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20460


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
parent cff6495b

scripts/perf/nvmf/run_nvmf.py

+9 −5
Original line number Diff line number Diff line
@@ -54,8 +54,9 @@ class Server(ABC): 
            ConfigField(name='transport', required=True),

            ConfigField(name='skip_spdk_install', default=False),

            ConfigField(name='irdma_roce_enable', default=False),

            ConfigField(name='pause_frames', default=False)

            ConfigField(name='pause_frames', default=None)

        ]



        self.read_config(config_fields, general_config)

        self.transport = self.transport.lower()
@@ -193,11 +194,14 @@ class Server(ABC): 
            self.exec_cmd(["sudo", "ethtool", "-A", nic_name, "rx", rx_state, "tx", tx_state])



    def configure_pause_frames(self):

        if not self.pause_frames:

        if self.pause_frames is None:

            self.log.info("Keeping NIC's default pause frames setting")

            return

        elif not self.pause_frames:

            self.log.info("Turning off pause frames")

            self.set_pause_frames("off", "off")

            return

        self.log.info("Configuring pause frames")

        else:

            self.log.info("Turning on pause frames")

            self.set_pause_frames("on", "on")



    def configure_arfs(self):