Commit aab7c20f authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

test/check_so_deps: parametrize the script options 



No longer rely on positional arguments when calling the
test script.

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Icc4726b50f0b34d99fdb6828b4fd03e83788e008
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19281


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@gmail.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 3f483d61

test/common/autobuild_common.sh

+1 −1
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ check_format() { 
}



check_so_deps() {

	run_test "autobuild_check_so_deps" "$rootdir/test/make/check_so_deps.sh" "$spdk_conf" "$SPDK_ABI_DIR"

	run_test "autobuild_check_so_deps" "$rootdir/test/make/check_so_deps.sh" -c "$spdk_conf" -a "$SPDK_ABI_DIR"

}



external_code() {

test/make/check_so_deps.sh

+39 −4
Original line number Diff line number Diff line
@@ -13,16 +13,51 @@ fi 
testdir=$(readlink -f $(dirname $0))

rootdir=$(readlink -f $testdir/../..)



function usage() {

	script_name="$(basename $0)"

	echo "Usage: $script_name"

	echo "    -c, --config-file     Rebuilds SPDK according to config file from autotest"

	echo "    -a, --spdk-abi-path   Use spdk-abi from specified path, otherwise"

	echo "                          latest version is pulled and deleted after test"

	echo "    -h, --help            Print this help"

	echo "Example:"

	echo "$script_name -c ./autotest.config -a /path/to/spdk-abi"

}



# Parse input arguments #

while getopts 'hc:a:-:' optchar; do

	case "$optchar" in

		-)

			case "$OPTARG" in

				help)

					usage

					exit 0

					;;

				config-file=*)

					config_file="$(readlink -f ${OPTARG#*=})"

					;;

				spdk-abi-path=*)

					user_abi_dir="$(readlink -f ${OPTARG#*=})"

					;;

				*) exit 1 ;;

			esac

			;;

		h)

			usage

			exit 0

			;;

		c) config_file="$(readlink -f ${OPTARG#*=})" ;;

		a) user_abi_dir="$(readlink -f ${OPTARG#*=})" ;;

		*) exit 1 ;;

	esac

done



source "$rootdir/test/common/autotest_common.sh"



config_file=$1

if [[ -e $config_file ]]; then

	source "$config_file"

fi



if [[ -d $2 ]]; then

	user_abi_dir="$2"

fi

source_abi_dir="${user_abi_dir:-"$testdir/abi"}"

libdir="$rootdir/build/lib"

libdeps_file="$rootdir/mk/spdk.lib_deps.mk"