Commit aaa1ddc3 authored by Jonas Pfefferle's avatar Jonas Pfefferle Committed by Jim Harris
Browse files

test/bdevio: only skip cmp & write if md separate 



While we do not support cmp & write with separate md we
do support it with extended LBA format, i.e. interleaved md.
The check was to permissive and we only need to skip the
test if the md is separate.

Signed-off-by: default avatarJonas Pfefferle <pepperjo@japf.ch>
Change-Id: I483a33c762a66036bf88e77e7fc88dcb609d391a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14138


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 8ffe1a75

test/bdev/bdevio/bdevio.c

+3 −3
Original line number Diff line number Diff line
@@ -639,12 +639,12 @@ blockdev_comparev_and_writev(void) 
	struct io_target *target = g_current_io_target;

	struct spdk_bdev *bdev = target->bdev;



	if (spdk_bdev_get_md_size(bdev) > 0) {

	if (spdk_bdev_is_md_separate(bdev)) {

		/* TODO: remove this check once bdev layer properly supports

		 * compare and write for md-enabled bdevs.

		 * compare and write for bdevs with separate md.

		 */

		SPDK_ERRLOG("skipping comparev_and_writev on bdev %s since it has\n"

			    "metadata which is not supported yet.\n",

			    "separate metadata which is not supported yet.\n",

			    spdk_bdev_get_name(bdev));

		return;

	}