Commit a9e1852d authored Sep 11, 2024 by kaushik.chug Committed by Konrad Sztyber Sep 12, 2024

lib/bdev: Change condition to send aborts for split ios



bdev_abort_io detects if this io was split based on checking
split_on_optimal_io_boundary & bio_to_abort->internal.f.split
variables. But even if split_on_optimal_io_boundary is not set
the bio can still split based on other variables mentioned in
bdev_rw_should_split. So if internal.f.split is set, that means
all these checks are already done and this flag is enough to
recognise if the bio had split or not.

Change-Id: I9d5c8a694bfe107bfb02040dde0ff6208dfc1386
Signed-off-by: kaushik.chug <kaushik.chug@ngxstorage.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24880


Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

parent 4c446029

lib/bdev/bdev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7013,7 +7013,7 @@ bdev_abort_io(struct spdk_bdev_desc desc, struct spdk_bdev_channel channel,
		bdev_io->type = SPDK_BDEV_IO_TYPE_ABORT;
		bdev_io_init(bdev_io, bdev, cb_arg, cb);

		if (bdev->split_on_optimal_io_boundary && bio_to_abort->internal.f.split) {
		if (bio_to_abort->internal.f.split) {
		assert(bdev_io_should_split(bio_to_abort));
		bdev_io->u.bdev.abort.bio_cb_arg = bio_to_abort;

Admin message