Commit a9b174e7 authored by Jim Harris's avatar Jim Harris
Browse files

build: fix duplicate spdk.common.mk includes



mk/nvme.libtest.mk includes mk/spdk.common.mk, but all
of the Makefiles including mk/nvme.libtest.mk were
also including mk/spdk.common.mk unnecessarily.  So
remove the spdk.common.mk include from all of the
offending Makefiles.

This was relatively harmless, although it would cause
weird things like CFLAGS and LDFLAGS getting duplicated
when building.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ie60637db3c19a2ead097562b2adf6573dbe27472

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455321


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 9018dd60
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@
#

SPDK_ROOT_DIR := $(CURDIR)/../../..
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

APP = arbitration

+0 −1
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@
#

SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

APP = cmb_copy

+0 −2
Original line number Diff line number Diff line
@@ -34,8 +34,6 @@

SPDK_ROOT_DIR := $(CURDIR)/../../..

include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

APP := fio_plugin

CFLAGS += -I$(CONFIG_FIO_SOURCE_DIR)
+0 −1
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@
#

SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

APP = hello_world

+0 −1
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@
#

SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

APP = hotplug

Loading