Commit a93e09ee authored by Wojciech Panfil's avatar Wojciech Panfil Committed by Tomasz Zawadzki
Browse files

spdk_top: Remove unused window elements 



mvwaddach(WINDOW*, y, x, sign) was given y=-1 which resulted in an error,
which was not detected, because retval of it has not been checked.
The window renders the same without these as they were tried to be rendered outside of the window.

Change-Id: Ice2f50e08da13b403a66427412cbe4164f541ef7
Signed-off-by: default avatarWojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18932


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 76afc412

app/spdk_top/spdk_top.c

+0 −4
Original line number Diff line number Diff line
@@ -2413,9 +2413,7 @@ draw_core_win_content(WINDOW *core_win, struct rpc_core_info *core_info) 
		 core_info->lcore);

	print_in_middle(core_win, 1, 0, CORE_WIN_WIDTH, core_win_title, COLOR_PAIR(3));



	mvwaddch(core_win, -1, 0, ACS_LTEE);

	mvwhline(core_win, 2, 1, ACS_HLINE, CORE_WIN_WIDTH - 2);

	mvwaddch(core_win, 2, CORE_WIN_WIDTH, ACS_RTEE);

	print_left(core_win, 3, 1, CORE_WIN_WIDTH - (CORE_WIN_WIDTH / 3),

		   "Frequency:             Intr:", COLOR_PAIR(5));

	if (core_info->core_freq) {
@@ -2428,9 +2426,7 @@ draw_core_win_content(WINDOW *core_win, struct rpc_core_info *core_info) 
	mvwprintw(core_win, 3, CORE_WIN_FIRST_COL + 15, "%s",

		  core_info->in_interrupt ? "Yes" : "No");



	mvwaddch(core_win, -1, 0, ACS_LTEE);

	mvwhline(core_win, 4, 1, ACS_HLINE, CORE_WIN_WIDTH - 2);

	mvwaddch(core_win, 4, CORE_WIN_WIDTH, ACS_RTEE);

	print_left(core_win, 5, 1, CORE_WIN_WIDTH, "Thread count:          Idle time:", COLOR_PAIR(5));



	mvwprintw(core_win, 5, CORE_WIN_FIRST_COL, "%" PRIu64,