Commit a82e8478 authored by Vasuki Manikarnike's avatar Vasuki Manikarnike Committed by Jim Harris
Browse files

lib/nvme: Do not retry aborts if ctrlr is failed. 



Fixes #2022

If queued aborts are present when trying to fail a ctrlr
using spdk_nvme_ctrlr_fail(), then the abort command completion
will attempt to retry one of the queued aborts.
This eventually leads to a segfault that can be avoided by not
retrying any queued aborts.

Change-Id: I897dcb8809e16af8bdd39d4381ab531e1cc29822
Signed-off-by: default avatarVasuki Manikarnike <vasuki.manikarnike@hpe.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8585


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent e6464f32

lib/nvme/nvme_ctrlr_cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -572,7 +572,7 @@ nvme_ctrlr_retry_queued_abort(struct spdk_nvme_ctrlr *ctrlr) 
	struct nvme_request	*next, *tmp;

	int rc;



	if (ctrlr->is_resetting || ctrlr->is_destructed) {

	if (ctrlr->is_resetting || ctrlr->is_destructed || ctrlr->is_failed) {

		return;

	}