Commit a805c7de authored by Karol Latecki's avatar Karol Latecki Committed by Jim Harris
Browse files

scripts/pkgdep.sh: add shellcheck installation. 



Add shellcheck package for bash syntax and styling checks.
Enabling in check_format.sh done in separate patch.

Change-Id: I654f4168d5fab55dc7e1eeaa353ea6da24d04dd7
Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463866


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 8a14af68

scripts/pkgdep.sh

+6 −4
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ function usage() 
{

	echo ""

	echo "This script is intended to automate the installation of package dependencies to build SPDK."

	echo "Please run this script as root user."

	echo "Please run this script as root user or with sudo -E."

	echo ""

	echo "$0"

	echo "  -h --help"
@@ -56,7 +56,7 @@ if [ -s /etc/redhat-release ]; then 


	yum install -y gcc gcc-c++ make CUnit-devel libaio-devel openssl-devel \

		git astyle python-pycodestyle lcov python libuuid-devel \

		sg3_utils libiscsi-devel pciutils

		sg3_utils libiscsi-devel pciutils ShellCheck

	# Additional (optional) dependencies for showing backtrace in logs

	yum install -y libunwind-devel || true

	# Additional dependencies for NVMe over Fabrics
@@ -76,7 +76,8 @@ if [ -s /etc/redhat-release ]; then 
elif [ -f /etc/debian_version ]; then

	# Includes Ubuntu, Debian

	apt-get install -y gcc g++ make libcunit1-dev libaio-dev libssl-dev \

		git astyle pep8 lcov clang uuid-dev sg3-utils libiscsi-dev pciutils

		git astyle pep8 lcov clang uuid-dev sg3-utils libiscsi-dev pciutils \

		shellcheck

	# Additional python style checker not available on ubuntu 16.04 or earlier.

	apt-get install -y pycodestyle || true

	# Additional (optional) dependencies for showing backtrace in logs
@@ -96,7 +97,8 @@ elif [ -f /etc/debian_version ]; then 
	apt-get install -y python3-paramiko

elif [ -f /etc/SuSE-release ] || [ -f /etc/SUSE-brand ]; then

	zypper install -y gcc gcc-c++ make cunit-devel libaio-devel libopenssl-devel \

		git-core lcov python-base python-pycodestyle libuuid-devel sg3_utils pciutils

		git-core lcov python-base python-pycodestyle libuuid-devel sg3_utils pciutils \

		ShellCheck

	# Additional (optional) dependencies for showing backtrace in logs

	zypper install libunwind-devel || true

	# Additional dependencies for NVMe over Fabrics