Commit a7d9fc4a authored by Darek Stojaczyk's avatar Darek Stojaczyk
Browse files

event: fix segv on json config read failure 



If reading the JSON config file has failed, we entered
spdk_app_json_config_load_done(-ERRNO) and tried to
close a client connection that was never initiated,
which resulted in NULL dereference.

To fix it, just check if client_conn != NULL before
attempting to close it.

Change-Id: I7340567c45e795f77110c2914e94ba83fa8d1bff
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/458350


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 7bf3ac17

lib/event/json_config.c

+4 −1
Original line number Diff line number Diff line
@@ -128,7 +128,10 @@ static void 
spdk_app_json_config_load_done(struct load_json_config_ctx *ctx, int rc)

{

	spdk_poller_unregister(&ctx->client_conn_poller);

	if (ctx->client_conn != NULL) {

		spdk_jsonrpc_client_close(ctx->client_conn);

	}



	spdk_rpc_finish();



	if (rc) {