Commit a7d816bf authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

ut/scsi/dev: fix memory leak in lun_construct stub 



Check if a LUN already exists before allocating the spdk_scsi_lun
structure - this matches the real implementation of
spdk_scsi_lun_construct().

Fixes: e44731d6 ("scsi: Remove the claimed flag from LUN")

Change-Id: I529648f93cd21e9f19ce82ef571cabe9c7e8c49a
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/390903


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
parent deddb8d8

test/unit/lib/scsi/dev.c/dev_ut.c

+7 −7
Original line number Diff line number Diff line
@@ -97,17 +97,17 @@ spdk_scsi_lun_construct(const char *name, struct spdk_bdev *bdev, 
	struct spdk_scsi_lun *lun;

	struct lun_entry *p;



	lun = calloc(1, sizeof(struct spdk_scsi_lun));

	SPDK_CU_ASSERT_FATAL(lun != NULL);



	snprintf(lun->name, sizeof(lun->name), "%s", name);

	lun->bdev = bdev;



	TAILQ_FOREACH(p, &g_lun_head, lun_entries) {

		CU_ASSERT_FATAL(p->lun != NULL);

		if (strncmp(p->lun->name, lun->name, sizeof(lun->name)) == 0)

		if (strcmp(p->lun->name, name) == 0) {

			return NULL;

		}

	}



	lun = calloc(1, sizeof(struct spdk_scsi_lun));

	SPDK_CU_ASSERT_FATAL(lun != NULL);

	snprintf(lun->name, sizeof(lun->name), "%s", name);

	lun->bdev = bdev;



	p = calloc(1, sizeof(struct lun_entry));

	SPDK_CU_ASSERT_FATAL(p != NULL);