Commit a7d79228 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

test/nvmf: remove silent skip of mDNS on RDMA 



Any script or function called with run_test needs to
either execute or not be called at all.
Summary of all test executions is gathered based on that.

It would be possible to not catch that the test didn't execute.

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ib93d4ee9cccbcfa8506f9022f1a7cce97c0434f1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16347


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 0485fb47

test/nvmf/host/mdns_discovery.sh

+0 −5
Original line number Diff line number Diff line
@@ -9,11 +9,6 @@ rootdir=$(readlink -f $testdir/../../..) 
source $rootdir/test/common/autotest_common.sh

source $rootdir/test/nvmf/common.sh



if [ "$TEST_TRANSPORT" == "rdma" ]; then

	echo "Skipping tests on RDMA because the rdma stack fails to configure the same IP for host and target."

	exit 0

fi



DISCOVERY_FILTER="address"

DISCOVERY_PORT=8009

DISCOVERY_NQN=nqn.2014-08.org.nvmexpress.discovery

test/nvmf/nvmf.sh

+2 −1
Original line number Diff line number Diff line
@@ -92,7 +92,8 @@ run_test "nvmf_discovery" test/nvmf/host/discovery.sh "${TEST_ARGS[@]}" 
# TODO: disabled due to intermittent failures (RDMA_CM_EVENT_UNREACHABLE/ETIMEDOUT)

#run_test test/nvmf/host/identify_kernel_nvmf.sh $TEST_ARGS



if [[ $SPDK_TEST_NVMF_MDNS -eq 1 ]]; then

if [[ $SPDK_TEST_NVMF_MDNS -eq 1 && "$SPDK_TEST_NVMF_TRANSPORT" == "tcp" ]]; then

	# Skipping tests on RDMA because the rdma stack fails to configure the same IP for host and target.

	run_test "nvmf_mdns_discovery" test/nvmf/host/mdns_discovery.sh "${TEST_ARGS[@]}"

fi