Commit a7a0d02d authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvme: fix command specific status code 



Given enum was not aligned with spec. This status can be reported when
size equals 0.

Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Change-Id: If51f6b051c13880c1fd4e6bb0a02f134b28b5a88
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/928


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 33d5eee1

include/spdk/nvme_spec.h

+1 −1
Original line number Diff line number Diff line
@@ -1195,7 +1195,7 @@ enum spdk_nvme_generic_command_status_code { 
enum spdk_nvme_command_specific_status_code {

	SPDK_NVME_SC_COMPLETION_QUEUE_INVALID		= 0x00,

	SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER		= 0x01,

	SPDK_NVME_SC_MAXIMUM_QUEUE_SIZE_EXCEEDED	= 0x02,

	SPDK_NVME_SC_INVALID_QUEUE_SIZE			= 0x02,

	SPDK_NVME_SC_ABORT_COMMAND_LIMIT_EXCEEDED	= 0x03,

	/* 0x04 - reserved */

	SPDK_NVME_SC_ASYNC_EVENT_REQUEST_LIMIT_EXCEEDED = 0x05,

lib/bdev/scsi_nvme.c

+1 −1
Original line number Diff line number Diff line
@@ -165,7 +165,7 @@ spdk_scsi_nvme_translate(const struct spdk_bdev_io *bdev_io, int *sc, int *sk, 
			*ascq = SPDK_SCSI_ASCQ_CAUSE_NOT_REPORTABLE;

			break;

		case SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER:

		case SPDK_NVME_SC_MAXIMUM_QUEUE_SIZE_EXCEEDED:

		case SPDK_NVME_SC_INVALID_QUEUE_SIZE:

		case SPDK_NVME_SC_ASYNC_EVENT_REQUEST_LIMIT_EXCEEDED:

		case SPDK_NVME_SC_INVALID_FIRMWARE_SLOT:

		case SPDK_NVME_SC_INVALID_FIRMWARE_IMAGE:

lib/nvme/nvme_qpair.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static const struct nvme_string generic_status[] = { 
static const struct nvme_string command_specific_status[] = {

	{ SPDK_NVME_SC_COMPLETION_QUEUE_INVALID, "INVALID COMPLETION QUEUE" },

	{ SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER, "INVALID QUEUE IDENTIFIER" },

	{ SPDK_NVME_SC_MAXIMUM_QUEUE_SIZE_EXCEEDED, "MAX QUEUE SIZE EXCEEDED" },

	{ SPDK_NVME_SC_INVALID_QUEUE_SIZE, "INVALID QUEUE SIZE" },

	{ SPDK_NVME_SC_ABORT_COMMAND_LIMIT_EXCEEDED, "ABORT CMD LIMIT EXCEEDED" },

	{ SPDK_NVME_SC_ASYNC_EVENT_REQUEST_LIMIT_EXCEEDED, "ASYNC LIMIT EXCEEDED" },

	{ SPDK_NVME_SC_INVALID_FIRMWARE_SLOT, "INVALID FIRMWARE SLOT" },