Commit a5156f64 authored by Yankun Li's avatar Yankun Li Committed by Tomasz Zawadzki
Browse files

bdev/nvme: check param hostnqn for attaching controller 



Change-Id: I4ce2daa0e8e9a0736b6504af1cb1b8625e6d7cfb
Signed-off-by: default avatarYankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22166


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
parent 245c82b2

module/bdev/nvme/bdev_nvme_rpc.c

+8 −2
Original line number Diff line number Diff line
@@ -429,8 +429,14 @@ rpc_bdev_nvme_attach_controller(struct spdk_jsonrpc_request *request, 
	}



	if (ctx->req.hostnqn) {

		snprintf(ctx->req.drv_opts.hostnqn, sizeof(ctx->req.drv_opts.hostnqn), "%s",

		maxlen = sizeof(ctx->req.drv_opts.hostnqn);

		len = strnlen(ctx->req.hostnqn, maxlen);

		if (len == maxlen) {

			spdk_jsonrpc_send_error_response_fmt(request, -EINVAL, "hostnqn too long: %s",

							     ctx->req.hostnqn);

			goto cleanup;

		}

		memcpy(ctx->req.drv_opts.hostnqn, ctx->req.hostnqn, len + 1);

	}



	if (ctx->req.psk) {