Commit a32ba316 authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Changpeng Liu
Browse files

vhost/nvme: remove cmd and cqe magic numbers 



Replace the hard-coded 64 and 16 constants, which are the size of the
submission queue entry and completion queue entry, with equivalent
sizeof expressions.

Change-Id: I5a9d8fc1ab98276312445f0699aae3d86beee705
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/408762


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 80e71078

lib/vhost/rte_vhost/vhost_user.c

+3 −3
Original line number Diff line number Diff line
@@ -1185,10 +1185,10 @@ vhost_user_msg_handler(int vid, int fd) 
		if (!dev->is_nvme) {

			dev->is_nvme = 1;

		}

		memcpy(cmd, &msg.payload.nvme.cmd, 64);

		memcpy(cmd, msg.payload.nvme.cmd.req, sizeof(cmd));

		ret = vhost_user_nvme_admin_passthrough(dev, cmd, cqe, buf);

		memcpy(&msg.payload.nvme.cmd, &cqe, 16);

		msg.size = 16;

		memcpy(msg.payload.nvme.cmd.cqe, cqe, sizeof(cqe));

		msg.size = sizeof(cqe);

		/* NVMe Identify Command */

		if (cmd[0] == 0x06) {

			memcpy(msg.payload.nvme.buf, &buf, 4096);