Commit a2653a72 authored by Jim Harris's avatar Jim Harris Committed by Konrad Sztyber
Browse files

test/unit/nvmf: simplify test_nvmf_tgt_create_poll_group 



Initialize fields through local "subsystem" variable
where possible, instead of more convoluted
"tgt.subsystems[0]".

This will simplify a future patch.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ia05f8ad325e074a5ba1cea0d74fa8f0695cf865b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17964


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 1967b6f5

test/unit/lib/nvmf/nvmf.c/nvmf_ut.c

+6 −6
Original line number Diff line number Diff line
@@ -159,13 +159,13 @@ test_nvmf_tgt_create_poll_group(void) 
	SPDK_CU_ASSERT_FATAL(tgt.subsystems != NULL);



	tgt.subsystems[0] = &subsystem;

	tgt.subsystems[0]->id = 0;

	tgt.subsystems[0]->max_nsid = 1;

	tgt.subsystems[0]->ns = calloc(1, sizeof(struct spdk_nvmf_ns *));

	SPDK_CU_ASSERT_FATAL(tgt.subsystems[0]->ns != NULL);

	subsystem.id = 0;

	subsystem.max_nsid = 1;

	subsystem.ns = calloc(1, sizeof(struct spdk_nvmf_ns *));

	SPDK_CU_ASSERT_FATAL(subsystem.ns != NULL);

	MOCK_SET(spdk_nvmf_subsystem_get_first, &subsystem);



	tgt.subsystems[0]->ns[0] = &ns;

	subsystem.ns[0] = &ns;

	ns.crkey = 0xaa;

	ns.rtype = 0xbb;

	TAILQ_INIT(&ns.registrants);
@@ -200,7 +200,7 @@ test_nvmf_tgt_create_poll_group(void) 
	nvmf_tgt_destroy_poll_group((void *)&tgt, (void *)&group);

	CU_ASSERT(TAILQ_EMPTY(&tgt.poll_groups));

	CU_ASSERT(tgt.num_poll_groups == 0);

	free(tgt.subsystems[0]->ns);

	free(subsystem.ns);

	free(tgt.subsystems);

	MOCK_CLEAR(spdk_nvmf_subsystem_get_first);