Commit a2070cf3 authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

hello_sock: fix iov_len check in callback. 



Currently we assign value of `rc`, which is of type
signed integer, to `iov.iov_len`, which is of type
size_t (unsigned integer). If rc == -1, then
iov.iov_len == UINT_MAX, which lets code enter
the if block, even when `spdk_sock_recv_next()`
failed.

Change-Id: I6ee83cf3f38660431385399ca28a02997ad1a701
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19464


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 6a458d3b

examples/sock/hello_world/hello_sock.c

+2 −3
Original line number Diff line number Diff line
@@ -328,9 +328,8 @@ hello_sock_cb(void *arg, struct spdk_sock_group *group, struct spdk_sock *sock) 
		}

	}



	if (rc > 0) {

		iov.iov_len = rc;



	if (iov.iov_len > 0) {

		ctx->bytes_in += iov.iov_len;

		n = spdk_sock_writev(sock, &iov, 1);

		if (n > 0) {