Commit a1246d4d authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

iscsi/portal_grp: improve port string validation 



Detect bad port strings before trying
spdk_sock_listen() to improve the error messages
for the user.

This also will reject '0' and '-0' as port numbers,
similar to recent fixes made for nvmf/tcp.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I8ea8a7fecd8a25020ab8505dec22f53b700622c9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20528


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
parent b189e65e

lib/iscsi/portal_grp.c

+5 −0
Original line number Diff line number Diff line
@@ -153,6 +153,11 @@ iscsi_portal_open(struct spdk_iscsi_portal *p) 
	}



	port = (int)strtol(p->port, NULL, 0);

	if (port <= 0 || port > 65535) {

		SPDK_ERRLOG("invalid port %s\n", p->port);

		return -1;

	}



	sock = spdk_sock_listen(p->host, port, NULL);

	if (sock == NULL) {

		SPDK_ERRLOG("listen error %.64s.%d\n", p->host, port);