Commit a0878680 authored by Seth Howell's avatar Seth Howell Committed by Tomasz Zawadzki
Browse files

include/spdk_internal: remove SPDK_LOG_NVME from nvme_tcp.h 



This file isn't exclusive to the nvme lib. As such, it shouldn't
use the internal SPDK_LOG_NVME flag.

Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Change-Id: Ib6d239ad2e45e58fb97a5ea70b01ce72afa938c0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2246


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 681b515d

include/spdk_internal/nvme_tcp.h

+2 −8
Original line number Diff line number Diff line
@@ -481,10 +481,7 @@ nvme_tcp_read_data(struct spdk_sock *sock, int bytes, 
		}



		/* For connect reset issue, do not output error log */

		if (errno == ECONNRESET) {

			SPDK_DEBUGLOG(SPDK_LOG_NVME, "spdk_sock_recv() failed, errno %d: %s\n",

				      errno, spdk_strerror(errno));

		} else {

		if (errno != ECONNRESET) {

			SPDK_ERRLOG("spdk_sock_recv() failed, errno %d: %s\n",

				    errno, spdk_strerror(errno));

		}
@@ -520,10 +517,7 @@ nvme_tcp_readv_data(struct spdk_sock *sock, struct iovec *iov, int iovcnt) 
		}



		/* For connect reset issue, do not output error log */

		if (errno == ECONNRESET) {

			SPDK_DEBUGLOG(SPDK_LOG_NVME, "spdk_sock_readv() failed, errno %d: %s\n",

				      errno, spdk_strerror(errno));

		} else {

		if (errno != ECONNRESET) {

			SPDK_ERRLOG("spdk_sock_readv() failed, errno %d: %s\n",

				    errno, spdk_strerror(errno));

		}

test/unit/lib/nvmf/tcp.c/tcp_ut.c

+0 −1
Original line number Diff line number Diff line
@@ -57,7 +57,6 @@ 
#define UT_NUM_SHARED_BUFFERS 128



SPDK_LOG_REGISTER_COMPONENT("nvmf", SPDK_LOG_NVMF)

SPDK_LOG_REGISTER_COMPONENT("nvme", SPDK_LOG_NVME)



DEFINE_STUB(spdk_nvmf_qpair_get_listen_trid,

	    int,