Commit 9f770dae authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

bdev/error: make sure error_disk is not NULL 



If the user specifies the name of a bdev that is not an error injection
bdev, bdev_inject_error would cause a NULL pointer dereference.

Change-Id: Ibcc7daee5a75ac37c3567ebc048662e0165c2860
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/365526


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarCunyin Chang <cunyin.chang@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 5091cadc

lib/bdev/error/vbdev_error.c

+6 −0
Original line number Diff line number Diff line
@@ -80,6 +80,12 @@ spdk_vbdev_inject_error(char *name, uint32_t io_type_mask, uint32_t error_num) 
		}

	}



	if (error_disk == NULL) {

		SPDK_ERRLOG("Could not find ErrorInjection bdev %s\n", name);

		pthread_mutex_unlock(&g_vbdev_error_mutex);

		return -1;

	}



	error_disk->io_type_mask = io_type_mask;

	error_disk->error_num = error_num;

	pthread_mutex_unlock(&g_vbdev_error_mutex);