Commit 9ef0f6a1 authored by Boris Glimcher's avatar Boris Glimcher Committed by Tomasz Zawadzki
Browse files

python/cli: nvmf_set_config validate input arguments 



check value of '-p|--passthru-admin-cmds' vs valid options

Change-Id: I0192cefb7e38c1fc2cc69479c3a8e4036bbe1b98
Signed-off-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26954


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
parent 4d00fb20

python/spdk/cli/nvmf.py

+4 −0
Original line number Diff line number Diff line
@@ -23,6 +23,10 @@ def add_parser(subparsers): 
    def nvmf_set_config(args):

        all_admin_cmd_passthru = ('identify_ctrlr', 'identify_uuid_list', 'get_log_page', 'get_set_features', 'sanitize',

                                  'security_send_recv', 'fw_update', 'nvme_mi', 'vendor_specific')

        invalid_admin_cmd_passthru = set(args.passthru_admin_cmds) - set(all_admin_cmd_passthru) - {'all'}

        if invalid_admin_cmd_passthru:

            print(f"Invalid passthru-admin-cmds: '{', '.join(invalid_admin_cmd_passthru)}'. See help for valid options.", file=sys.stderr)

            exit(1)

        if not args.passthru_admin_cmds:

            admin_cmd_passthru = None

        elif 'all' in args.passthru_admin_cmds: