Commit 9d2060ee authored by Boris Glimcher's avatar Boris Glimcher Committed by Tomasz Zawadzki
Browse files

test: unify code to use same bracket syntax 



= {0}; - first element set to zero, everything else recursively zeroed.
= {{0}}; -  explicitly saying “first member, which is itself a struct/union, is {0}.”
= {}; - shorthand allowed since C23 (and as a GNU extension in GCC/Clang before that). It means “default-initialize everything”, which for structs is the same as zero-initialize.

In strict C99/C11, = {}; is not valid — you’d need = {0};.
In GNU C / Clang, = {}; has worked for ages as an extension.
In C23, = {}; is finally standard.

Change-Id: Ie91969d9df3037b143976edc88c273559e471405
Signed-off-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26722


Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
parent a60bee0c

test/unit/lib/bdev/raid/bdev_raid_sb.c/bdev_raid_sb_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -194,7 +194,7 @@ write_sb_cb(int status, struct raid_bdev *raid_bdev, void *ctx) 
static void

test_raid_bdev_write_superblock(void)

{

	struct raid_base_bdev_info base_info[3] = {{0}};

	struct raid_base_bdev_info base_info[3] = {};

	struct raid_bdev raid_bdev = {

		.num_base_bdevs = SPDK_COUNTOF(base_info),

		.base_bdev_info = base_info,

test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c

+2 −2
Original line number Diff line number Diff line
@@ -2362,8 +2362,8 @@ test_nvme_ctrlr_init_delay(void) 
static void

test_spdk_nvme_ctrlr_set_trid(void)

{

	struct spdk_nvme_ctrlr ctrlr = {{0}};

	struct spdk_nvme_transport_id new_trid = {{0}};

	struct spdk_nvme_ctrlr ctrlr = {};

	struct spdk_nvme_transport_id new_trid = {};



	CU_ASSERT(pthread_mutex_init(&ctrlr.ctrlr_lock, NULL) == 0);

test/unit/lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c

+4 −4
Original line number Diff line number Diff line
@@ -574,8 +574,8 @@ test_nvme_ns_cmd_flush(void) 
static void

test_nvme_ns_cmd_write_zeroes(void)

{

	struct spdk_nvme_ns	ns = { 0 };

	struct spdk_nvme_ctrlr	ctrlr = {{0}};

	struct spdk_nvme_ns	ns = {};

	struct spdk_nvme_ctrlr	ctrlr = {};

	struct spdk_nvme_qpair	qpair;

	spdk_nvme_cmd_cb	cb_fn = NULL;

	void			*cb_arg = NULL;
@@ -601,8 +601,8 @@ test_nvme_ns_cmd_write_zeroes(void) 
static void

test_nvme_ns_cmd_write_uncorrectable(void)

{

	struct spdk_nvme_ns	ns = { 0 };

	struct spdk_nvme_ctrlr	ctrlr = {{0}};

	struct spdk_nvme_ns	ns = {};

	struct spdk_nvme_ctrlr	ctrlr = {};

	struct spdk_nvme_qpair	qpair;

	spdk_nvme_cmd_cb	cb_fn = NULL;

	void			*cb_arg = NULL;

test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c

+5 −5
Original line number Diff line number Diff line
@@ -156,11 +156,11 @@ dummy_cb_fn(void *cb_arg, const struct spdk_nvme_cpl *cpl) 
static void

test_nvme_qpair_process_completions(void)

{

	struct spdk_nvme_qpair		admin_qp = {0};

	struct spdk_nvme_qpair		qpair = {0};

	struct spdk_nvme_ctrlr		ctrlr = {{0}};

	struct nvme_request		dummy_1 = {{0}};

	struct nvme_request		dummy_2 = {{0}};

	struct spdk_nvme_qpair		admin_qp = {};

	struct spdk_nvme_qpair		qpair = {};

	struct spdk_nvme_ctrlr		ctrlr = {};

	struct nvme_request		dummy_1 = {};

	struct nvme_request		dummy_2 = {};

	int				rc;



	dummy_1.cb_fn = dummy_cb_fn;

test/unit/lib/nvme/nvme_rdma.c/nvme_rdma_ut.c

+16 −16
Original line number Diff line number Diff line
@@ -182,10 +182,10 @@ static void 
test_nvme_rdma_build_sgl_request(void)

{

	struct nvme_rdma_qpair rqpair = {};

	struct spdk_nvme_ctrlr ctrlr = {0};

	struct spdk_nvmf_cmd cmd = {{0}};

	struct spdk_nvme_rdma_req rdma_req = {0};

	struct nvme_request req = {{0}};

	struct spdk_nvme_ctrlr ctrlr = {};

	struct spdk_nvmf_cmd cmd = {};

	struct spdk_nvme_rdma_req rdma_req = {};

	struct nvme_request req = {};

	struct nvme_rdma_ut_bdev_io bio = { .iovcnt = NVME_RDMA_MAX_SGL_DESCRIPTORS };

	uint64_t i;

	int rc;
@@ -291,10 +291,10 @@ static void 
test_nvme_rdma_build_sgl_inline_request(void)

{

	struct nvme_rdma_qpair rqpair = {};

	struct spdk_nvme_ctrlr ctrlr = {0};

	struct spdk_nvmf_cmd cmd = {{0}};

	struct spdk_nvme_rdma_req rdma_req = {0};

	struct nvme_request req = {{0}};

	struct spdk_nvme_ctrlr ctrlr = {};

	struct spdk_nvmf_cmd cmd = {};

	struct spdk_nvme_rdma_req rdma_req = {};

	struct nvme_request req = {};

	struct nvme_rdma_ut_bdev_io bio = { .iovcnt = NVME_RDMA_MAX_SGL_DESCRIPTORS };

	int rc;
@@ -352,10 +352,10 @@ static void 
test_nvme_rdma_build_contig_request(void)

{

	struct nvme_rdma_qpair rqpair = {};

	struct spdk_nvme_ctrlr ctrlr = {0};

	struct spdk_nvmf_cmd cmd = {{0}};

	struct spdk_nvme_rdma_req rdma_req = {0};

	struct nvme_request req = {{0}};

	struct spdk_nvme_ctrlr ctrlr = {};

	struct spdk_nvmf_cmd cmd = {};

	struct spdk_nvme_rdma_req rdma_req = {};

	struct nvme_request req = {};

	int rc;



	ctrlr.max_sges = NVME_RDMA_MAX_SGL_DESCRIPTORS;
@@ -395,10 +395,10 @@ static void 
test_nvme_rdma_build_contig_inline_request(void)

{

	struct nvme_rdma_qpair rqpair = {};

	struct spdk_nvme_ctrlr ctrlr = {0};

	struct spdk_nvmf_cmd cmd = {{0}};

	struct spdk_nvme_rdma_req rdma_req = {0};

	struct nvme_request req = {{0}};

	struct spdk_nvme_ctrlr ctrlr = {};

	struct spdk_nvmf_cmd cmd = {};

	struct spdk_nvme_rdma_req rdma_req = {};

	struct nvme_request req = {};

	int rc;



	ctrlr.max_sges = NVME_RDMA_MAX_SGL_DESCRIPTORS;