Commit 9d1e6667 authored Jun 26, 2019 by Anil Veerabhadrappa Committed by Changpeng Liu Jun 28, 2019

conf: parse "C2HSuccess" parameter for TCP transport only



"C2HSuccess" is only valid for TCP transport. So this parameter
should be looked up only for TCP transport. Without the change,
spdk_nvmf_parse_transport() would bailout early for RDMA and
other transports without every creating them.

Signed-off-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I34bdff2f4ab930516743cd5dbf022d75e60fd85c
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459571


Reviewed-by: Maciej Szwed <maciej.szwed@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent 4ebf5cef

lib/event/subsystems/nvmf/conf.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -557,12 +557,9 @@ spdk_nvmf_parse_transport(struct spdk_nvmf_parse_transport_ctx *ctx)
		}
		}

		bval = spdk_conf_section_get_boolval(ctx->sp, "C2HSuccess", true);
		if (trtype == SPDK_NVME_TRANSPORT_TCP) {
		bval = spdk_conf_section_get_boolval(ctx->sp, "C2HSuccess", true);
		opts.c2h_success = bval;
		} else {
		SPDK_ERRLOG("C2HSuccess is relevant only for TCP transport '%s'\n", type);
		goto error_out;
		}

		transport = spdk_nvmf_transport_create(trtype, &opts);

Admin message