Commit 9d1b8599 authored Sep 14, 2018 by Shuhei Matsumoto Committed by Jim Harris Sep 26, 2018

bdev/raid: Remove duplicated error check in construct RPC



This part was duplicated but was not removed during refactoring caressly.

Additionally, the variable iter was not changed to the single character
variable i too.

Fix them in this patch.

Change-Id: I1e026434ce48e9e8d492a3aa772c3be6df0b1d37
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/425528


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 37368624

lib/bdev/raid/bdev_raid_rpc.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -184,8 +184,8 @@ static void
		free_rpc_construct_raid_bdev(struct rpc_construct_raid_bdev *req)
		{
		free(req->name);
		for (size_t iter = 0; iter < req->base_bdevs.num_base_bdevs; iter++) {
		free(req->base_bdevs.base_bdevs[iter]);
		for (size_t i = 0; i < req->base_bdevs.num_base_bdevs; i++) {
		free(req->base_bdevs.base_bdevs[i]);
		}
		}

		@@ -280,14 +280,6 @@ spdk_rpc_construct_raid_bdev(struct spdk_jsonrpc_request *request,
		return;
		}

		if (rc != 0) {
		spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
		"Failed to add base bdev to RAID bdev %s: %s",
		req.name, spdk_strerror(-rc));
		free_rpc_construct_raid_bdev(&req);
		return;
		}

		free_rpc_construct_raid_bdev(&req);

		w = spdk_jsonrpc_begin_result(request);