Commit 9cdd1a8a authored by Changpeng Liu's avatar Changpeng Liu Committed by Tomasz Zawadzki
Browse files

lib/vhost: remove `vhost_session_used_signal` function 



`vdev_worker` in vhost-scsi is used to process request queues,
and `vdev_mgmt_worker` is used to process the event and control
queue, so we don't need to call `vhost_session_used_signal` in
`vdev_worker`, just remove it.

Change-Id: I86f3e90890e6defba69b01fec131afe1adad3a49
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14927


Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 7fcbd022

lib/vhost/rte_vhost_user.c

+0 −12
Original line number Diff line number Diff line
@@ -469,18 +469,6 @@ vhost_session_vq_used_signal(struct spdk_vhost_virtqueue *virtqueue) 
	}

}



void

vhost_session_used_signal(struct spdk_vhost_session *vsession)

{

	struct spdk_vhost_virtqueue *virtqueue;

	uint16_t q_idx;



	for (q_idx = 0; q_idx < vsession->max_queues; q_idx++) {

		virtqueue = &vsession->virtqueue[q_idx];

		vhost_session_vq_used_signal(virtqueue);

	}

}



/*

 * Enqueue id and len to used ring.

 */

lib/vhost/vhost_internal.h

+0 −8
Original line number Diff line number Diff line
@@ -301,14 +301,6 @@ int vhost_inflight_queue_get_desc(struct spdk_vhost_session *vsession, 
 */

int vhost_vq_used_signal(struct spdk_vhost_session *vsession, struct spdk_vhost_virtqueue *vq);





/**

 * Send IRQs for all queues that need to be signaled.

 * \param vsession vhost session

 * \param vq virtqueue

 */

void vhost_session_used_signal(struct spdk_vhost_session *vsession);



/**

 * Send IRQs for the queue that need to be signaled.

 * \param vq virtqueue

lib/vhost/vhost_scsi.c

+1 −2
Original line number Diff line number Diff line
@@ -815,10 +815,9 @@ vdev_worker(void *arg) 


	for (q_idx = VIRTIO_SCSI_REQUESTQ; q_idx < vsession->max_queues; q_idx++) {

		rc = process_vq(svsession, &vsession->virtqueue[q_idx]);

		vhost_session_vq_used_signal(&vsession->virtqueue[q_idx]);

	}



	vhost_session_used_signal(vsession);



	return rc > 0 ? SPDK_POLLER_BUSY : SPDK_POLLER_IDLE;

}