Commit 9cb78e1a authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

nvmf: change some ERRLOGs to DEBUGLOGs 



We generally shouldn't do ERRLOGs based on bad
inputs from the host, so change some of these to
DEBUGLOGs instead.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Id42a8e51964e0238cd2841be8ac1d4ccaa1d150d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10037


Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarDong Yi <dongx.yi@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 4c5774fd

lib/nvmf/ctrlr.c

+4 −4
Original line number Diff line number Diff line
@@ -1259,7 +1259,7 @@ nvmf_property_get(struct spdk_nvmf_request *req) 
		size = 8;

		break;

	default:

		SPDK_ERRLOG("Invalid size value %d\n", cmd->attrib.size);

		SPDK_DEBUGLOG(nvmf, "Invalid size value %d\n", cmd->attrib.size);

		response->status.sct = SPDK_NVME_SCT_COMMAND_SPECIFIC;

		response->status.sc = SPDK_NVMF_FABRIC_SC_INVALID_PARAM;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;
@@ -1317,7 +1317,7 @@ nvmf_property_set(struct spdk_nvmf_request *req) 
		size = 8;

		break;

	default:

		SPDK_ERRLOG("Invalid size value %d\n", cmd->attrib.size);

		SPDK_DEBUGLOG(nvmf, "Invalid size value %d\n", cmd->attrib.size);

		response->status.sct = SPDK_NVME_SCT_COMMAND_SPECIFIC;

		response->status.sc = SPDK_NVMF_FABRIC_SC_INVALID_PARAM;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;
@@ -2299,7 +2299,7 @@ nvmf_ctrlr_get_log_page(struct spdk_nvmf_request *req) 
	uint8_t lid;



	if (req->data == NULL) {

		SPDK_ERRLOG("get log command with no buffer\n");

		SPDK_DEBUGLOG(nvmf, "get log command with no buffer\n");

		response->status.sct = SPDK_NVME_SCT_GENERIC;

		response->status.sc = SPDK_NVME_SC_INVALID_FIELD;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;
@@ -2685,7 +2685,7 @@ nvmf_ctrlr_identify(struct spdk_nvmf_request *req) 
	struct spdk_nvmf_subsystem *subsystem = ctrlr->subsys;



	if (req->data == NULL || req->length < 4096) {

		SPDK_ERRLOG("identify command with invalid buffer\n");

		SPDK_DEBUGLOG(nvmf, "identify command with invalid buffer\n");

		rsp->status.sct = SPDK_NVME_SCT_GENERIC;

		rsp->status.sc = SPDK_NVME_SC_INVALID_FIELD;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;