Commit 9c6c3a8c authored May 19, 2023 by Ziye Yang Committed by Tomasz Zawadzki May 23, 2023

uring: Fix the code broken when zero-copy send is enabled.



Without this fix, the program will hang in the target side.
If we use SPDK NVMe-of target with tcp transport with uring,

./scripts/rpc.py sock_impl_set_options --enable-zerocopy-send-server -i uring

Then we use nvmf initiator to test, the program hangs.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18236

 (master)

(cherry picked from commit a14bc376)
Change-Id: Iea12ee0396008481e8317424d1f405eb03634ed4
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18278


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent e1308e90

module/sock/uring/uring.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1405,8 +1405,7 @@ sock_uring_group_reap(struct spdk_uring_sock_group_impl *group, int max, int max
		_sock_prep_errqueue(&sock->base);
		} else if (status == -ECANCELED) {
		continue;
		} else if (spdk_unlikely(status <= 0)) {
		sock->connection_status = status < 0 ? status : -ECONNRESET;
		} else if (spdk_unlikely(status < 0)) {
		spdk_sock_abort_requests(&sock->base);

		/* The user needs to be notified that this socket is dead. */

Admin message