Commit 9c5c2cf7 authored by Ziye Yang's avatar Ziye Yang Committed by Jim Harris
Browse files

lib/iscsi: Move last_nopin update in spdk_iscsi_send_nopin 



If we are not in ffp phase, we do not need to update last_nopin

Change-Id: I289beec8437d7117b6261483c333bf5db5fbd11f
Signed-off-by: default avatarZiye Yang <optimistyzy@gmail.com>
Reviewed-on: https://review.gerrithub.io/403166


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 1732428a

lib/iscsi/conn.c

+0 −1
Original line number Diff line number Diff line
@@ -913,7 +913,6 @@ spdk_iscsi_conn_handle_nop(struct spdk_iscsi_conn *conn) 
			conn->state = ISCSI_CONN_STATE_EXITING;

		}

	} else if (tsc - conn->last_nopin > conn->nopininterval) {

		conn->last_nopin = tsc;

		spdk_iscsi_send_nopin(conn);

	}

}

lib/iscsi/iscsi.c

+1 −0
Original line number Diff line number Diff line
@@ -4312,6 +4312,7 @@ void spdk_iscsi_send_nopin(struct spdk_iscsi_conn *conn) 
	to_be32(&rsp->max_cmd_sn, conn->sess->MaxCmdSN);



	spdk_iscsi_conn_write_pdu(conn, rsp_pdu);

	conn->last_nopin = spdk_get_ticks();

	conn->nop_outstanding = true;

}