Commit 9c47dd8e authored by Pawel Kaminski's avatar Pawel Kaminski Committed by Tomasz Zawadzki
Browse files

test: shellcheck - move rule SC2086 to permanent exclude list 



SC2086: Double quote to prevent globbing and word splitting.

Change-Id: Ia427dbb3b5d5ad20bcc09a3a455b80d0f69fb583
Signed-off-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477266


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 8d4ecf1e

scripts/check_format.sh

+4 −3
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ if hash shellcheck 2>/dev/null; then 
	# go to: https://trello.com/c/29Z90j1W

	# Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki

	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1083,SC2002,SC2010,SC2034,SC2045,SC2046,SC2086"

	SHCK_EXCLUDE="SC1083,SC2002,SC2010,SC2034,SC2045,SC2046"

	# SPDK fails some error checks which have been deprecated in later versions of shellcheck.

	# We will not try to fix these error checks, but instead just leave the error types here

	# so that we can still run with older versions of shellcheck.
@@ -252,6 +252,7 @@ if hash shellcheck 2>/dev/null; then 
	# SC2001: See if you can use ${variable//search/replace} instead.

	# SC2015: Note that A && B || C is not if-then-else. C may run when A is true.

	# SC2016: Expressions don't expand in single quotes, use double quotes for that.

	# SC2086: Double quote to prevent globbing and word splitting.

	# SC2119: Use foo "$@" if function's $1 should mean script's $1.

	# SC2120: foo references arguments, but none are ever passed.

	# SC2148: Add shebang to the top of your script.
@@ -263,8 +264,8 @@ if hash shellcheck 2>/dev/null; then 
	#         or split robustly with mapfile or read -a.

	# SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).

	# SC2223: This default assignment may cause DoS due to globbing. Quote it.

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2015,SC2016,SC2119,SC2120,SC2148,SC2153,SC2154,SC2164,\

SC2174,SC2001,SC2206,SC2207,SC2223"

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2015,SC2016,SC2086,SC2119,SC2120,SC2148,\

SC2153,SC2154,SC2164,SC2174,SC2001,SC2206,SC2207,SC2223"



	SHCK_FORMAT="diff"

	SHCK_APPLY=true