Commit 9b47757b authored by GangCao's avatar GangCao Committed by Tomasz Zawadzki
Browse files

test/qos: update the IO result calculation 



There is possible overflow when getting throughput as
that value is in byte and we also use tick for the
calculation.

Change-Id: Id1f0fd4903af5e8362f1fcafebac33223d36eb34
Signed-off-by: default avatarGangCao <gang.cao@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475475


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 4342c0f0

test/bdev/blockdev.sh

+11 −4
Original line number Diff line number Diff line
@@ -76,7 +76,14 @@ function get_io_result() { 
	fi

	ticks_after=$(echo $io_result | jq -r '.ticks')



	echo $((((io_result_after-io_result_before)*tick_rate)/(ticks_after-ticks_before)))

	if [ $limit_type = IOPS ]; then

		io_result_diff=$((io_result_after-io_result_before))

	else

		# To avoid potential overflow as throughput is in byte

		# Return throughput in kilobyte

		io_result_diff=$(((io_result_after-io_result_before)/1024))

	fi

	echo $(((io_result_diff*tick_rate)/(ticks_after-ticks_before)))

}



function run_qos_test() {
@@ -85,11 +92,11 @@ function run_qos_test() { 


	qos_result=$(get_io_result $2)

	if [ $2 = BANDWIDTH ]; then

		qos_limit=$((qos_limit*1024*1024))

		qos_limit=$((qos_limit*1024))

	fi

	lower_limit=$((qos_limit*9/10))

	upper_limit=$((qos_limit*11/10))



	lower_limit=$(echo "$qos_limit 0.9" | awk '{printf("%i",$1*$2)}')

	upper_limit=$(echo "$qos_limit 1.1" | awk '{printf("%i",$1*$2)}')

	# QoS realization is related with bytes transfered. It currently has some variation.

	if [ $qos_result -lt $lower_limit ] || [ $qos_result -gt $upper_limit ]; then

		echo "Failed to limit the io read rate of NULL bdev by qos"